dotnet / dotnet/csharp-tmLanguage

interpolated strings interpolation should use different embedded scope

Open
#158 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
78
Forks
43
Avg merge
34m
Merged PRs (30d)
1

Description

## Details

VS Code 1.36 Custom Theme

The interpolated content in an interpolated string should use scope `meta.embedded` from the point of `punctuation.definition.interpolation.begin.cs`, which should really be `punctuation.section.embedded.begin.cs`, to take advantage of most themes reversing the color back to standard code, for the meta.embedded scope, and special highlighting for the `punctuation.section.embedded` scope.

## Repro

From a section of the PowerShell repository:
![image](https://user-images.githubusercontent.com/26179051/61837431-5fd33180-ae4a-11e9-909e-5301afb39e4b.png)

An example of the mentioned scopes shown in a special build of the PowerShell tmLanguage file, showing PowerShell interpolated string content in a script:
![image](https://user-images.githubusercontent.com/26179051/61837747-bee57600-ae4b-11e9-9e4d-4bb91c091304.png)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.