dotnet / dotnet/core

Api reviewer does not support new language features which leads to errors in our api-diff

Open
#6,908 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PowerShell
Stars
22k
Forks
4.9k
Avg merge
5d 5h
Merged PRs (30d)
29

Description

We currently use a version of asmdiff (api reviewer) to generate api-diffs. This tool depends on cci and is not able to catch the new language features like nint or RequiresPreviewFeatures

It might be a good idea to move api -reviewer from cci to roslyn as handling issues due to these features is not scalable.

cc @tannergooding @ericstj @safern

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.