dotnet / dotnet/command-line-api
List<CliToken> tokenList should be renamed to List<CliToken> tokens
Open
- Dominant language
- C#
- Stars
- 3.7k
- Forks
- 428
- PR merge metrics
- No merged PRs in 30d
Description
There are a few mentions of `tokenList` left in `Tokenizer.Tokenize` and they should be renamed to remove the type "List" so that the naming conforms to the conventions of the .NET Framework.
Also, where `(CliSymbol Symbol, CliTokenType TokenType)> tokens` is used, the word `tokens` should be changed to `validTokens` to avoid any confusion between the list of valid tokens and the list of tokens being built up.
Contributor guide
Assessment
This issue has not been assessed yet.