dotnet / dotnet/command-line-api

GetCompletions should check exit code of invoked application

Open
#2,137 1 comment 3 reactions 0 assignees View on GitHub
Area-Completions bug help wanted
Dominant language
C#
Stars
3.7k
Forks
428
PR merge metrics
No merged PRs in 30d

Description

This code should probably check the exit code and **not** consider standard output to be completions when it is non-zero:

https://github.com/dotnet/command-line-api/blob/403234a4c4247151d09073bc07ccc13530ce62c6/src/System.CommandLine.Suggest/SuggestionStore.cs#L47-L50

cc @jonsequitur @adamsitnik

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.