dotnet / dotnet/aspnetcore

Some samples do not work out of box

Open
#7,288 3 comments 0 reactions 0 assignees View on GitHub
affected-few area-auth severity-minor task
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 5h
Merged PRs (30d)
276

Description

At least the following samples do not work if you do `.\build.cmd` move into their directory and do `dotnet run`.

- [OpenIdConnect.AzureAdSample](https://github.com/aspnet/AspNetCore/tree/master/src/Security/Authentication/OpenIdConnect/samples/OpenIdConnect.AzureAdSample)
- [WsFederation](https://github.com/aspnet/AspNetCore/tree/master/src/Security/Authentication/WsFederation/samples/WsFedSample)
- [OpenIdConnectSample](https://github.com/aspnet/AspNetCore/tree/master/src/Security/Authentication/OpenIdConnect/samples/OpenIdConnectSample)

These samples should either be fixed so that an outside user can run them without modification (or if modification is required for config or some such, it should be explicitly called out in the error message), or removed entirely if they no longer serve a purpose.

More generally it would be a good idea for us build and test basic functionality of all our samples (IE, index page returns 200) so we can ensure that they are up to date and not misleading to customers.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.