dotnet / dotnet/aspnetcore

Cleanup custom handling of Obsolete attribute once we get updates from STJ flowing

Open
#67,958 1 comment 1 reaction 0 assignees View on GitHub
area-minimal feature-openapi
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 5h
Merged PRs (30d)
276

Description

See #66355

The PR manually adds deprecated property to the schema when ObsoleteAttribute is found on type/property.

This was recently implemented on JsonSchemaExporter side in https://github.com/dotnet/runtime/pull/130665, but the runtime change hasn't flown to aspnetcore yet. Once it flows, we should try to cleanup the implementation on our side and rely on JsonSchemaExporter doing it.

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the implementation from #66355 and the JsonSchemaExporter change in dotnet/runtime PR #130665; verify that the runtime update has flowed to aspnetcore. Then locate the custom ObsoleteAttribute schema handling and remove it only when exporter behavior is available, confirming the generated schema still includes the expected deprecated information.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
backend-api-design
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.