dotnet / dotnet/aspnetcore

SignalR MessagePackHubProtocol should handle the EXTENSION value type.

Open
#66,895 11 comments 0 reactions 0 assignees View on GitHub
area-signalr feature-client-java
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 5h
Merged PRs (30d)
276

Description

### Is there an existing issue for this?

- [x] I have searched the existing issues

### Is your feature request related to a problem? Please describe the problem.

I am using the signal R client to get data from a signal R server. Unfortunately, the MessagePackHubProtocol doesn't handle the EXTENSION value type.
It's commented out and it would be really useful uncommented.

### Describe the solution you'd like

Uncomment the code, and break to get out of the switch. Of course remove the RuntimeException throwing.
Adapt the relevant unit test MessagePackHubProtocolTest.

### Additional context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.