dotnet / dotnet/aspnetcore

Regarding function naming

Open
#65,537 0 comments 0 reactions 0 assignees View on GitHub
area-signalr
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 10h
Merged PRs (30d)
281

Description

@microsoft/signalr 10.0.0

Regarding the naming of callback functions, will camelCase be adopted in the future? It looks strange now. For example, changing 'onreconnecting' to 'onReconnecting' and 'onreconnected' to 'onReconnected' and 'onclose' to 'onClose', my cspell plugin also prompts me:

[https://github.com/dotnet/aspnetcore/blob/eec80e1c63963802a215d58b3907d6e46090fc28/src/SignalR/clients/ts/signalr/src/HubConnection.ts#L570`onclose`](https://github.com/dotnet/aspnetcore/blob/eec80e1c63963802a215d58b3907d6e46090fc28/src/SignalR/clients/ts/signalr/src/HubConnection.ts#L570%60onclose%60)

Image

Image

Contributor guide

Open the contributing guide

Research direction

Start with src/SignalR/clients/ts/signalr/src/HubConnection.ts at the referenced line and inspect the onclose, onreconnecting, and onreconnected callback API. Review how these names are exposed and whether changing them would affect compatibility; done would require a decided naming direction and the associated API and test updates.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.