dotnet / dotnet/aspnetcore

Healthcheck log message with redundant HealthCheckName (both in log message and in log scope)

Open
#65,323 0 comments 0 reactions 0 assignees View on GitHub
area-healthchecks
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 10h
Merged PRs (30d)
281

Description

Hello,

It seems the log scope AND the log both contain the same HealthCheckName.
The scope being set, it might be interesting to not log again the HealthCheckName in the log message?

https://github.com/dotnet/dotnet/blob/cacb05bea9ad9caab93a40b24799b15ea2547188/src/aspnetcore/src/HealthChecks/HealthChecks/src/DefaultHealthCheckService.cs#L251

Thank you

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.