dotnet / dotnet/aspnetcore

Consider re-adding .AddRewrite API with default skip flag

Open
#5,988 1 comment 0 reactions 0 assignees View on GitHub
area-middleware feature-rewrite-middleware
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 10h
Merged PRs (30d)
281

Description

In #105 we remove an API from rewrite middleware because we worried it might hide potential perf problems for users. This removal requires users to explicitly declare "skipProcessingRules" on each call to .AddRewrite. We should reconsidering adding .AddRewrite with a default skipProcessingRules = false.

See https://github.com/aspnet/BasicMiddleware/pull/105#pullrequestreview-1880064 for more context.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.