dotnet / dotnet/aspnetcore

The split between desktop and dotnet msbuild in build.ps1 adds unnecessary complexity to the build

Open
#59,151 0 comments 0 reactions 1 assignee Claimed by @wtgodbe View on GitHub
area-infrastructure Priority:2
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 10h
Merged PRs (30d)
281

Description

With https://github.com/dotnet/aspnetcore/pull/58987, the entire repository can be built with a single build invocation on Windows: `eng\build.cmd -msbuildengine vs -restore -all -pack -publish -BuildInstallers` (that's what we use in the VMR to build aspnetcore).

The same should be possible when using dotnet msbuild as the entry-point by isolating the components that require desktop msbuild (vcxproj and wixproj) and building them with a shelled-out VS Dev Command Prompt which has desktop msbuild on the path. We do that in dotnet/runtime for similar VS only tools.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.