dotnet / dotnet/aspnetcore

Improve test ability of TOTP

Open
#5,761 0 comments 0 reactions 0 assignees View on GitHub
affected-very-few area-identity enhancement severity-nice-to-have
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 10h
Merged PRs (30d)
281

Description

IMHO TOTP needs to use ISystemClock to allow for testing to skew clock outside TOTP TimeStep, also at present the TimeStep is fixed at 3 mins which result in a window of 9 mins either side of the time the code was issued, this should be configurable with a note that a larger worn is less secure and a smaller windows is more prone to expire.

ie. when using an authenticator application a small windows of 2 mins is suffice
while using email/phone TOTP systems a larger window is required due to delays in communication of the code to the user

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.