dotnet / dotnet/aspnetcore

Trace id confused with traceparent from http context in ProblemDetails Extensions?

Open
#57,576 0 comments 1 reaction 0 assignees View on GitHub
area-networking
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 10h
Merged PRs (30d)
281

Description

## Summary

from httpContext trace identifier - we actually get trace parent which is of [this](https://github.com/w3c/trace-context/blob/main/spec/20-http_request_header_format.md) format:

```
version
trace-id
parent-id
trace-flags
```

I wanted to know why are we using traceId name instead of trace-parent while adding this value to problemDetails.Extensions [here:](https://github.com/dotnet/aspnetcore/blob/main/src/Mvc/Mvc.Core/src/Infrastructure/DefaultProblemDetailsFactory.cs)

Am I understanding it wrong?? should the
traceId be renamed to traceParent?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.