dotnet / dotnet/aspnetcore

The latest 11.x JDK does not appear to be used on helix

Open
#57,476 5 comments 0 reactions 0 assignees View on GitHub
area-infrastructure
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 6h
Merged PRs (30d)
290

Description

#56210 and #56211 both intended to update our repo to use the latest 11.x JDK, but those changes do not appear to affect our helix runs. I'm guessing we want to use the same JDK everywhere.

https://github.com/dotnet/aspnetcore/blob/30fb87ca055beb5997ab3f28d02bbc7866e8b683/eng/targets/Helix.targets#L3-L4

I do not think our InstallJdk.ps1 or installjdk.sh scripts support leaving the minor version and patch unspecified. If you try, you get 404 responses from https://netcorenativeassets.blob.core.windows.net.

This can also hinder local development, because unlike in `release/8.0`, `.\eng\scripts\InstallJdk.ps1` fails in `main` and `release/9.0` unless a version with a patch is explicitly specified, since it only reads JDK version "11" in global.json. It's unclear what JDK versions are available. 11.0.3 appears to exist for Windows, but not 11.0.23, and it doesn't appear to be possible to anonymously list available versions.

@wtgodbe @BrennanConroy

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.