dotnet / dotnet/aspnetcore

Signing during test project builds

Open
#56,721 0 comments 0 reactions 0 assignees View on GitHub
area-mvc
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 6h
Merged PRs (30d)
290

Description

When we build this repo on RHEL9 CI some test projects fail to build due to RHEL9 crypto policy not allowing the RSA+SHA1 signing.

Is the signing functionally required for these tests?

The failures include: `MinimalSampleFSharp`

```
FSC : error FS2014: A problem occurred writing the binary '/home/tester/aspnetcore/artifacts/obj/MinimalSampleFSharp/Release/net9.0/MinimalSampleFSharp.dll': Error while writing debug directory entry: Warning: A call to SignFile failed (error:03000098:digital envelope routines::invalid digest) [/home/tester/aspnetcore/src/Http/samples/MinimalSampleFSharp/MinimalSampleFSharp.fsproj]
```

And `Microsoft.AspNetCore.Mvc.DataAnnotations.Test/Microsoft.AspNetCore.Mvc.IntegrationTests/Microsoft.AspNetCore.OpenApi.Microbenchmarks` when calling the compiler:
```
/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets(89,5): error : Unhandled exception. Interop+Crypto+OpenSslCryptographicException: error:03000098:digital envelope routines::invalid digest [/home/tester/aspnetcore/src/Mvc/Mvc.DataAnnotations/test/Microsoft.AspNetCore.Mvc.DataAnnotations.Test.csproj]
##vso[task.logissue type=error;sourcepath=/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets;linenumber=89;columnnumber=5;code=;](NETCORE_ENGINEERING_TELEMETRY=Build) Unhandled exception. Interop+Crypto+OpenSslCryptographicException: error:03000098:digital envelope routines::invalid digest
/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets(89,5): error : at Interop.Crypto.RsaSignHash(SafeEvpPKeyHandle pkey, RSASignaturePaddingMode paddingMode, IntPtr digestAlgorithm, ReadOnlySpan`1 hash, Span`1 destination) [/home/tester/aspnetcore/src/Mvc/Mvc.DataAnnotations/test/Microsoft.AspNetCore.Mvc.DataAnnotations.Test.csproj]
##vso[task.logissue type=error;sourcepath=/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets;linenumber=89;columnnumber=5;code=;](NETCORE_ENGINEERING_TELEMETRY=Build) at Interop.Crypto.RsaSignHash(SafeEvpPKeyHandle pkey, RSASignaturePaddingMode paddingMode, IntPtr digestAlgorithm, ReadOnlySpan`1 hash, Span`1 destination)
/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets(89,5): error : at System.Security.Cryptography.RSAOpenSsl.TrySignHash(ReadOnlySpan`1 hash, Span`1 destination, HashAlgorithmName hashAlgorithm, RSASignaturePadding padding, Boolean allocateSignature, Int32& bytesWritten, Byte[]& signature) [/home/tester/aspnetcore/src/Mvc/Mvc.DataAnnotations/test/Microsoft.AspNetCore.Mvc.DataAnnotations.Test.csproj]
##vso[task.logissue type=error;sourcepath=/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets;linenumber=89;columnnumber=5;code=;](NETCORE_ENGINEERING_TELEMETRY=Build) at System.Security.Cryptography.RSAOpenSsl.TrySignHash(ReadOnlySpan`1 hash, Span`1 destination, HashAlgorithmName hashAlgorithm, RSASignaturePadding padding, Boolean allocateSignature, Int32& bytesWritten, Byte[%5D& signature)
/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets(89,5): error : at System.Security.Cryptography.RSAOpenSsl.SignHash(Byte[] hash, HashAlgorithmName hashAlgorithm, RSASignaturePadding padding) [/home/tester/aspnetcore/src/Mvc/Mvc.DataAnnotations/test/Microsoft.AspNetCore.Mvc.DataAnnotations.Test.csproj]
##vso[task.logissue type=error;sourcepath=/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets;linenumber=89;columnnumber=5;code=;](NETCORE_ENGINEERING_TELEMETRY=Build) at System.Security.Cryptography.RSAOpenSsl.SignHash(Byte[%5D hash, HashAlgorithmName hashAlgorithm, RSASignaturePadding padding)
/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets(89,5): error : at Microsoft.CodeAnalysis.SigningUtilities.CalculateRsaSignature(IEnumerable`1 content, RSAParameters privateKey) [/home/tester/aspnetcore/src/Mvc/Mvc.DataAnnotations/test/Microsoft.AspNetCore.Mvc.DataAnnotations.Test.csproj]
##vso[task.logissue type=error;sourcepath=/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets;linenumber=89;columnnumber=5;code=;](NETCORE_ENGINEERING_TELEMETRY=Build) at Microsoft.CodeAnalysis.SigningUtilities.CalculateRsaSignature(IEnumerable`1 content, RSAParameters privateKey)
/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets(89,5): error : at Microsoft.CodeAnalysis.DesktopStrongNameProvider.<>c__DisplayClass12_0.b__0(IEnumerable`1 content) [/home/tester/aspnetcore/src/Mvc/Mvc.DataAnnotations/test/Microsoft.AspNetCore.Mvc.DataAnnotations.Test.csproj]
##vso[task.logissue type=error;sourcepath=/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets;linenumber=89;columnnumber=5;code=;](NETCORE_ENGINEERING_TELEMETRY=Build) at Microsoft.CodeAnalysis.DesktopStrongNameProvider.<>c__DisplayClass12_0.b__0(IEnumerable`1 content)
/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets(89,5): error : at System.Reflection.PortableExecutable.PEBuilder.Sign(BlobBuilder peImage, Blob strongNameSignatureFixup, Func`2 signatureProvider) [/home/tester/aspnetcore/src/Mvc/Mvc.DataAnnotations/test/Microsoft.AspNetCore.Mvc.DataAnnotations.Test.csproj]
##vso[task.logissue type=error;sourcepath=/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets;linenumber=89;columnnumber=5;code=;](NETCORE_ENGINEERING_TELEMETRY=Build) at System.Reflection.PortableExecutable.PEBuilder.Sign(BlobBuilder peImage, Blob strongNameSignatureFixup, Func`2 signatureProvider)
/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets(89,5): error : at Microsoft.Cci.PeWriter.WritePeToStream(EmitContext context, CommonMessageProvider messageProvider, Func`1 getPeStream, Func`1 getPortablePdbStreamOpt, PdbWriter nativePdbWriterOpt, String pdbPathOpt, Boolean metadataOnly, Boolean isDeterministic, Boolean emitTestCoverageData, Nullable`1 privateKeyOpt, CancellationToken cancellationToken) [/home/tester/aspnetcore/src/Mvc/Mvc.DataAnnotations/test/Microsoft.AspNetCore.Mvc.DataAnnotations.Test.csproj]
##vso[task.logissue type=error;sourcepath=/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets;linenumber=89;columnnumber=5;code=;](NETCORE_ENGINEERING_TELEMETRY=Build) at Microsoft.Cci.PeWriter.WritePeToStream(EmitContext context, CommonMessageProvider messageProvider, Func`1 getPeStream, Func`1 getPortablePdbStreamOpt, PdbWriter nativePdbWriterOpt, String pdbPathOpt, Boolean metadataOnly, Boolean isDeterministic, Boolean emitTestCoverageData, Nullable`1 privateKeyOpt, CancellationToken cancellationToken)
/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets(89,5): error : at Microsoft.CodeAnalysis.Compilation.SerializePeToStream(CommonPEModuleBuilder moduleBeingBuilt, DiagnosticBag metadataDiagnostics, CommonMessageProvider messageProvider, Func`1 getPeStream, Func`1 getMetadataPeStreamOpt, Func`1 getPortablePdbStreamOpt, PdbWriter nativePdbWriterOpt, String pdbPathOpt, RebuildData rebuildData, Boolean metadataOnly, Boolean includePrivateMembers, Boolean isDeterministic, Boolean emitTestCoverageData, Nullable`1 privateKeyOpt, CancellationToken cancellationToken) [/home/tester/aspnetcore/src/Mvc/Mvc.DataAnnotations/test/Microsoft.AspNetCore.Mvc.DataAnnotations.Test.csproj]
##vso[task.logissue type=error;sourcepath=/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets;linenumber=89;columnnumber=5;code=;](NETCORE_ENGINEERING_TELEMETRY=Build) at Microsoft.CodeAnalysis.Compilation.SerializePeToStream(CommonPEModuleBuilder moduleBeingBuilt, DiagnosticBag metadataDiagnostics, CommonMessageProvider messageProvider, Func`1 getPeStream, Func`1 getMetadataPeStreamOpt, Func`1 getPortablePdbStreamOpt, PdbWriter nativePdbWriterOpt, String pdbPathOpt, RebuildData rebuildData, Boolean metadataOnly, Boolean includePrivateMembers, Boolean isDeterministic, Boolean emitTestCoverageData, Nullable`1 privateKeyOpt, CancellationToken cancellationToken)
/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets(89,5): error : at Microsoft.CodeAnalysis.Compilation.SerializeToPeStream(CommonPEModuleBuilder moduleBeingBuilt, EmitStreamProvider peStreamProvider, EmitStreamProvider metadataPEStreamProvider, EmitStreamProvider pdbStreamProvider, RebuildData rebuildData, Func`2 testSymWriterFactory, DiagnosticBag diagnostics, EmitOptions emitOptions, Nullable`1 privateKeyOpt, CancellationToken cancellationToken) [/home/tester/aspnetcore/src/Mvc/Mvc.DataAnnotations/test/Microsoft.AspNetCore.Mvc.DataAnnotations.Test.csproj]
##vso[task.logissue type=error;sourcepath=/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets;linenumber=89;columnnumber=5;code=;](NETCORE_ENGINEERING_TELEMETRY=Build) at Microsoft.CodeAnalysis.Compilation.SerializeToPeStream(CommonPEModuleBuilder moduleBeingBuilt, EmitStreamProvider peStreamProvider, EmitStreamProvider metadataPEStreamProvider, EmitStreamProvider pdbStreamProvider, RebuildData rebuildData, Func`2 testSymWriterFactory, DiagnosticBag diagnostics, EmitOptions emitOptions, Nullable`1 privateKeyOpt, CancellationToken cancellationToken)
/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets(89,5): error : at Microsoft.CodeAnalysis.CommonCompiler.CompileAndEmit(TouchedFileLogger touchedFilesLogger, Compilation& compilation, ImmutableArray`1 analyzers, ImmutableArray`1 generators, ImmutableArray`1 additionalTextFiles, AnalyzerConfigSet analyzerConfigSet, ImmutableArray`1 sourceFileAnalyzerConfigOptions, ImmutableArray`1 embeddedTexts, DiagnosticBag diagnostics, ErrorLogger errorLogger, CancellationToken cancellationToken, CancellationTokenSource& analyzerCts, AnalyzerDriver& analyzerDriver, Nullable`1& generatorTimingInfo) [/home/tester/aspnetcore/src/Mvc/Mvc.DataAnnotations/test/Microsoft.AspNetCore.Mvc.DataAnnotations.Test.csproj]
##vso[task.logissue type=error;sourcepath=/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets;linenumber=89;columnnumber=5;code=;](NETCORE_ENGINEERING_TELEMETRY=Build) at Microsoft.CodeAnalysis.CommonCompiler.CompileAndEmit(TouchedFileLogger touchedFilesLogger, Compilation& compilation, ImmutableArray`1 analyzers, ImmutableArray`1 generators, ImmutableArray`1 additionalTextFiles, AnalyzerConfigSet analyzerConfigSet, ImmutableArray`1 sourceFileAnalyzerConfigOptions, ImmutableArray`1 embeddedTexts, DiagnosticBag diagnostics, ErrorLogger errorLogger, CancellationToken cancellationToken, CancellationTokenSource& analyzerCts, AnalyzerDriver& analyzerDriver, Nullable`1& generatorTimingInfo)
/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets(89,5): error : at Microsoft.CodeAnalysis.CommonCompiler.RunCore(TextWriter consoleOutput, ErrorLogger errorLogger, CancellationToken cancellationToken) [/home/tester/aspnetcore/src/Mvc/Mvc.DataAnnotations/test/Microsoft.AspNetCore.Mvc.DataAnnotations.Test.csproj]
##vso[task.logissue type=error;sourcepath=/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets;linenumber=89;columnnumber=5;code=;](NETCORE_ENGINEERING_TELEMETRY=Build) at Microsoft.CodeAnalysis.CommonCompiler.RunCore(TextWriter consoleOutput, ErrorLogger errorLogger, CancellationToken cancellationToken)
/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets(89,5): error : at Microsoft.CodeAnalysis.CommonCompiler.Run(TextWriter consoleOutput, CancellationToken cancellationToken) [/home/tester/aspnetcore/src/Mvc/Mvc.DataAnnotations/test/Microsoft.AspNetCore.Mvc.DataAnnotations.Test.csproj]
##vso[task.logissue type=error;sourcepath=/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets;linenumber=89;columnnumber=5;code=;](NETCORE_ENGINEERING_TELEMETRY=Build) at Microsoft.CodeAnalysis.CommonCompiler.Run(TextWriter consoleOutput, CancellationToken cancellationToken)
/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets(89,5): error : at Microsoft.CodeAnalysis.CSharp.CommandLine.Csc.<>c__DisplayClass1_0.b__0(TextWriter tw) [/home/tester/aspnetcore/src/Mvc/Mvc.DataAnnotations/test/Microsoft.AspNetCore.Mvc.DataAnnotations.Test.csproj]
##vso[task.logissue type=error;sourcepath=/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets;linenumber=89;columnnumber=5;code=;](NETCORE_ENGINEERING_TELEMETRY=Build) at Microsoft.CodeAnalysis.CSharp.CommandLine.Csc.<>c__DisplayClass1_0.b__0(TextWriter tw)
/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets(89,5): error : at Microsoft.CodeAnalysis.CSharp.CommandLine.Csc.Run(String[] args, BuildPaths buildPaths, TextWriter textWriter, IAnalyzerAssemblyLoader analyzerLoader) [/home/tester/aspnetcore/src/Mvc/Mvc.DataAnnotations/test/Microsoft.AspNetCore.Mvc.DataAnnotations.Test.csproj]
##vso[task.logissue type=error;sourcepath=/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets;linenumber=89;columnnumber=5;code=;](NETCORE_ENGINEERING_TELEMETRY=Build) at Microsoft.CodeAnalysis.CSharp.CommandLine.Csc.Run(String[%5D args, BuildPaths buildPaths, TextWriter textWriter, IAnalyzerAssemblyLoader analyzerLoader)
/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets(89,5): error : at Microsoft.CodeAnalysis.CommandLine.BuildClient.RunCompilation(IEnumerable`1 originalArguments, BuildPaths buildPaths, TextWriter textWriter, String pipeName) [/home/tester/aspnetcore/src/Mvc/Mvc.DataAnnotations/test/Microsoft.AspNetCore.Mvc.DataAnnotations.Test.csproj]
##vso[task.logissue type=error;sourcepath=/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets;linenumber=89;columnnumber=5;code=;](NETCORE_ENGINEERING_TELEMETRY=Build) at Microsoft.CodeAnalysis.CommandLine.BuildClient.RunCompilation(IEnumerable`1 originalArguments, BuildPaths buildPaths, TextWriter textWriter, String pipeName)
/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets(89,5): error : at Microsoft.CodeAnalysis.CommandLine.BuildClient.Run(IEnumerable`1 arguments, RequestLanguage language, CompileFunc compileFunc, CompileOnServerFunc compileOnServerFunc, ICompilerServerLogger logger) [/home/tester/aspnetcore/src/Mvc/Mvc.DataAnnotations/test/Microsoft.AspNetCore.Mvc.DataAnnotations.Test.csproj]
##vso[task.logissue type=error;sourcepath=/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets;linenumber=89;columnnumber=5;code=;](NETCORE_ENGINEERING_TELEMETRY=Build) at Microsoft.CodeAnalysis.CommandLine.BuildClient.Run(IEnumerable`1 arguments, RequestLanguage language, CompileFunc compileFunc, CompileOnServerFunc compileOnServerFunc, ICompilerServerLogger logger)
/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets(89,5): error : at Microsoft.CodeAnalysis.CSharp.CommandLine.Program.MainCore(String[] args) [/home/tester/aspnetcore/src/Mvc/Mvc.DataAnnotations/test/Microsoft.AspNetCore.Mvc.DataAnnotations.Test.csproj]
##vso[task.logissue type=error;sourcepath=/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets;linenumber=89;columnnumber=5;code=;](NETCORE_ENGINEERING_TELEMETRY=Build) at Microsoft.CodeAnalysis.CSharp.CommandLine.Program.MainCore(String[%5D args)
/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets(89,5): error : at Microsoft.CodeAnalysis.CSharp.CommandLine.Program.Main(String[] args) [/home/tester/aspnetcore/src/Mvc/Mvc.DataAnnotations/test/Microsoft.AspNetCore.Mvc.DataAnnotations.Test.csproj]
##vso[task.logissue type=error;sourcepath=/home/tester/aspnetcore/.dotnet/sdk/9.0.100-preview.7.24358.6/Roslyn/Microsoft.CSharp.Core.targets;linenumber=89;columnnumber=5;code=;](NETCORE_ENGINEERING_TELEMETRY=Build) at Microsoft.CodeAnalysis.CSharp.CommandLine.Program.Main(String[%5D args)
```

cc @dougbu @omajid

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.