dotnet / dotnet/aspnetcore

Investigate perf improvements for ProblemDetailsService interactions in ProblemHttpResult

Open
#56,439 1 comment 0 reactions 0 assignees View on GitHub
area-minimal feature-problem-details Perf
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 6h
Merged PRs (30d)
290

Description

Follow up to https://github.com/dotnet/aspnetcore/pull/51464#discussion_r1384382775.

In `ValidationProblem` and `ProblemHttpResult`, we use the following to check if the `ProblemDetailsService` is able to construct a `ProblemDetails` object:

https://github.com/dotnet/aspnetcore/blob/7aa68a31f5a460c5dab3d134621e8bb9eed51b0b/src/Http/Http.Results/src/ProblemHttpResult.cs#L62-L64

We should investigate if it is possible to avoid allocating a context object and removing the additional overhead of the async calls from this codepath.

Prior to that, we should do some profiling to measure what the additional impact here is.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.