dotnet / dotnet/aspnetcore

Redis output caching garbage collection routine should create an Activity to represent its work

Open
#53,335 3 comments 0 reactions 0 assignees View on GitHub
area-mvc feature-observability feature-output-caching
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 10h
Merged PRs (30d)
281

Description

If you create a new .NET Aspire application using the starter template, then run the app, hit the website, and then leave it running for at least 5 minutes, you'll see the following traces appear in the dashboard:

image

These are 4 root-level spans that represent the Redis operations performed by the [Redis output caching provider's garbage collection routine](https://github.com/dotnet/aspnetcore/blob/f545e80531c098e7c1611eca861b0f080fa14a3c/src/Middleware/Microsoft.AspNetCore.OutputCaching.StackExchangeRedis/src/RedisOutputCacheStore.cs#L126).

Since these are part of the same logical operation, the provider should create an `Activity` to represent the garbage collection iteration so that these spans created by the Redis client are collected as children of a parent span representing the garbage collection operation.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.