General feedback on kestrel connection metrics
- Dominant language
- C#
- Stars
- 38.4k
- Forks
- 10.9k
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 290
Description
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Is your feature request related to a problem? Please describe the problem.
Not related to any functional problem.
### Describe the solution you'd like
Several [kestrel connection metrics](https://github.com/open-telemetry/semantic-conventions/blob/e95fde026557e42fa832887b416b772101921986/docs/dotnet/dotnet-kestrel-metrics.md) could be grouped together to better align with otel recommendations.
See the original discussion in https://github.com/open-telemetry/semantic-conventions/pull/283#discussion_r1400552625
TL;DR:
`kestrel.active_connections`, `kestrel.queued_connections` could be measured with something like `kestrel.current.connections` or `kestrel.connections` and additional attribute like `kestrel.connection.state` = `active` | `queued`.
`kestrel.upgraded_connections` might also be measured with the same counter using an attribute that captures original protocol version (e.g. `http.protocol.initial_version`).
### Additional context
_No response_
Contributor guide
Assessment
This issue has not been assessed yet.