dotnet / dotnet/aspnetcore

SourceGen NativeOverlapped PInvokes

Open
#51,863 0 comments 0 reactions 0 assignees View on GitHub
area-networking blocked feature-httpsys
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 6h
Merged PRs (30d)
290

Description

https://github.com/microsoft/CsWin32/issues/1066 is an issue we encountered when [adopting](https://github.com/dotnet/aspnetcore/pull/50685/) the pinvoke source generator. We were unable to update any methods using NativeOverlapped such as HttpApi.HttpWaitForDisconnectEx. When it's fixed, update the CsWin32 and see if we can remove the remaining pinvoke definitions from HttpApi.cs.

What we do about our SafeNativeOverlapped wrapper is an open question I wasn't able to investigate due to the above issue. Maybe it can go away too.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.