dotnet / dotnet/aspnetcore

Add activities to SignalR invocations

Open
#51,557 11 comments 22 reactions 1 assignee Claimed by @BrennanConroy View on GitHub
area-signalr
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 6h
Merged PRs (30d)
290

Description

Today SignalR invocations do not have any activity associated with them. We currently piggy-back on the default ASP.NET Core activity and it's not great for invocations over the websocket. We should add an activity following the [semantic conventions for rpc](https://opentelemetry.io/docs/specs/semconv/rpc/rpc-spans/).

Open questions:
- Should we do this tracing in all directions? Client to server and server to client?
- Do we use message headers to pass this state across the wire seamlessly? This will impact the performance of invocations.

cc @BrennanConroy

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.