dotnet / dotnet/aspnetcore

The possibility of making SocketConnectionFactory public.

Open
#49,891 3 comments 4 reactions 0 assignees View on GitHub
api-suggestion area-networking
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 6h
Merged PRs (30d)
290

Description

### Is there an existing issue for this?

- [X] I have searched the existing issues

### Is your feature request related to a problem? Please describe the problem.

Just like how[ `SocketTransportFactory` ](https://github.com/dotnet/aspnetcore/blob/main/src/Servers/Kestrel/Transport.Sockets/src/SocketTransportFactory.cs) is public, I think making [`SocketConnectionFactory`](https://github.com/dotnet/aspnetcore/blob/main/src/Servers/Kestrel/Transport.Sockets/src/Client/SocketConnectionFactory.cs) public as well would be more consistent and make sense. I also would like to use it in a project of mine. 😀

### Describe the solution you'd like

Should be as simple as replacing `internal` with `public`.
(If possible, I'd like this issue to be assigned to me, so that I can do that change 😊).

### Additional context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.