dotnet / dotnet/aspnetcore

Fix nullability warnings in projects targeting netstandard2.0

Open
#47,179 15 comments 2 reactions 0 assignees View on GitHub
area-blazor area-hosting area-mvc area-networking Pillar: Technical Debt
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 6h
Merged PRs (30d)
290

Description

We have MSBuild targets in the repo that enable nullability on netstandard2.0 projects.

https://github.com/dotnet/aspnetcore/blob/07937702255861896d9ec34e28c7c0c59ceb6a3f/eng/targets/CSharp.Common.targets#L120-L130

However, the nullability warnings are not emitted during build by default.

https://github.com/dotnet/aspnetcore/blob/07937702255861896d9ec34e28c7c0c59ceb6a3f/eng/targets/CSharp.Common.targets#L125

Removing the property above shows that we have ~150 unhandled nullability warnings in the projects that currently "enable" nullability.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.