Improve HttpResponse.OnCompleted and RegisterForDispose XML docs
Open
area-networking
- Dominant language
- C#
- Stars
- 38.4k
- Forks
- 10.9k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 281
Description
Question that came up about OnCompleted:
> Is HttpResponse::OnCompleted guaranteed to be called at the end of request processing including all failure scenarios such as connection drop by client, server side request processing timeout, client side request processing timeout, etc.
Improve XML docs to clarify that the `OnCompleted` callback is always executed or RegisterForDispose always disposes the registered object.
Can also update `IHttpResponseFeature.OnCompleted`
Contributor guide
Assessment
This issue has not been assessed yet.