dotnet / dotnet/aspnetcore

IClaimsTransformation "runs on AuthorizeAsync success"

Open
#4,668 9 comments 0 reactions 0 assignees View on GitHub
area-auth
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 5h
Merged PRs (30d)
276

Description

The current action of IClaimsTransformation provides non-deterministic identity types on IPrincipal. For example, in the simple scenario where cookies are enabled, IClaimsTransformation does not get run if no cookies are present. In previous versions this transform could be relied upon to permit casting identity to a custom type. In Core 2.0 code breaks, and distributing null checks throughout code is necessary again, defeating the purpose of the transformation.

I'd just like to point out that this is an issue commonly seen on and off in various previous versions of Microsoft's identity, and from my perspective at this point seems to be a serious regression.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.