dotnet / dotnet/aspnetcore

Duplicate logging ID and name in health checks

Open
#46,099 6 comments 0 reactions 0 assignees View on GitHub
area-healthchecks
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 5h
Merged PRs (30d)
276

Description

### Is there an existing issue for this?

- [X] I have searched the existing issues

### Describe the bug

Health checks reuses a logging ID and name for end events at different log levels. We don't do this anywhere else in ASP.NET Core.

https://github.com/dotnet/aspnetcore/blob/4535ea1263e9a24ca8d37b7266797fe1563b8b12/src/HealthChecks/HealthChecks/src/DefaultHealthCheckService.cs#L220-L229

### Expected Behavior

I think we should have different log messages for different events to be consistent with the rest of the logging.

### Steps To Reproduce

_No response_

### Exceptions (if any)

_No response_

### .NET Version

_No response_

### Anything else?

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.