SignalR source generators shouldn't include Compilation in the pipeline
Open
area-signalr
- Dominant language
- C#
- Stars
- 38.4k
- Forks
- 10.9k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 281
Description
See https://github.com/dotnet/roslyn-analyzers/issues/6352
These pipelines are not efficient and this generator is not really incremental.
https://github.com/dotnet/aspnetcore/blob/d2f7bd0b37b7fed379d694b3231e6c5ddd177819/src/SignalR/clients/csharp/Client.SourceGenerator/src/HubClientProxyGenerator.cs#L15-L32
https://github.com/dotnet/aspnetcore/blob/d2f7bd0b37b7fed379d694b3231e6c5ddd177819/src/SignalR/clients/csharp/Client.SourceGenerator/src/HubServerProxyGenerator.cs#L15-L32
Every typed character in IDE will produce a new compilation and the whole thing will re-run. This doesn't benefit from being incremental.
Contributor guide
Assessment
This issue has not been assessed yet.