dotnet / dotnet/aspnetcore

[Analyzer] MinRequestBodyDataRate or MinResponseDataRate set to null

Open
#44,238 2 comments 0 reactions 0 assignees View on GitHub
analyzer area-networking
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 5h
Merged PRs (30d)
276

Description

### Is your feature request related to a problem? Please describe the problem.

Disabling MinRequestBodyDataRate or MinResponseDataRate can subject the app to DOS attacks.

### Describe the solution you'd like

An analyzer that looks at what these values are set to.

Also, there is a feature to set these values (at least the request data rate) per request. Should also check what it is set to.

### Additional context

It's common for apps to experience disconnect issues as a secondary symptom of a bigger app problem like threadpool starvation. Developers mistakenly try to mitigate this by disabling these minimum rates. We should refer them to better diagnostics docs instead.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.