dotnet / dotnet/aspnetcore

Response Caching should ignore the host part of the request

Open
#43,271 6 comments 0 reactions 1 assignee Claimed by @sebastienros View on GitHub
area-networking feature-response-caching
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 5h
Merged PRs (30d)
276

Description

Ideally, response caching should really only take notice from the path onwards (with all the great options for query parameters and headers of course) sine `http://mydomain.com/images/logo.png` and `https://mydomain.com/images/logo.png` and `http://192.168.1.1/images/logo.png` and `https://www.mydomain.com/images/logo.png` should be the same resource (since they are actually the same file) and only cache once (and when one is replaced, so should all the others).

So I thought maybe I could just register a new `IResponseCachingKeyProvider` that provided a different implementation of the key, but all the interfaces are `internal` - so much of open for extensibility :-(

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.