dotnet / dotnet/aspnetcore

Build our own packages using FrameworkReference

Open
#4,257 5 comments 1 reaction 0 assignees View on GitHub
affected-very-few area-infrastructure severity-nice-to-have
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 10h
Merged PRs (30d)
281

Description

Depends on https://github.com/NuGet/Home/issues/7342.
Follow up to https://github.com/aspnet/AspNetCore/pull/4178

The packages we ship which reference the shared framework should be built using `FrameworkReference`. Once https://github.com/NuGet/Home/issues/7342 is resolved, the metadata for this item will be preserved in the nuspec, which should ensure consumers get all the necessary runtime settings and compiler references.

**Workaround**
Consumers using our AspNetCore packages, such as Microsoft.AspNetCore.NodeServices, need to make sure they also have ``. This will be implicitly added with Microsoft.NET.Sdk.Web, but not other MSBuild SDKs.

**Changes required**

1. We need to change our own packages to build with `FrameworkReference`. (Related work #4246)
2. Update our SDK in BuildTools to support using `FrameworkReference`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.