dotnet / dotnet/aspnetcore

W3CLoggerProcessor doesn't update fields directive when it changes

Open
#42,059 4 comments 0 reactions 0 assignees View on GitHub
area-networking bug
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 6h
Merged PRs (30d)
290

Description

FileLoggerProcessor rolls to a new file & updates the fields set when it changes:

https://github.com/dotnet/aspnetcore/blob/b083d7de3981b1ac3dc2fdc72a53e5ad07172567/src/Middleware/HttpLogging/src/FileLoggerProcessor.cs#L64-L72

But W3CLoggerProcessor doesn't. We should fix this for 7 - maybe just pass in the set of fields directly from the middleware every time. Example proposed change set from @halter73: https://github.com/dotnet/aspnetcore/compare/dotnet:b806844...dotnet:a4d9f19?expand=1

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.