dotnet / dotnet/aspnetcore

Hub methods can soft-lock the connection

Open
#41,997 3 comments 0 reactions 1 assignee Claimed by @BrennanConroy View on GitHub
area-signalr severity-blocking
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 5h
Merged PRs (30d)
276

Description

Today we detect if you allow parallel hub invocations and throw if you don't when trying to use the feature. This doesn't work if you use IHubContext in the Hub, or if you have multiple waiting results for the same connections Hubs.
This is also especially bad in OnConnectedAsync because that's a special method that runs before the receive loop starts, we need to throw/unblock/warn etc. for this

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.