dotnet / dotnet/aspnetcore

Public setter for HttpClient in Java Client

Open
#40,534 2 comments 10 reactions 0 assignees View on GitHub
api-suggestion area-signalr
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 10h
Merged PRs (30d)
281

Description

Please make class com.microsoft.signalr.**HttpClient** and function com.microsoft.signalr.HttpHubConnectionBuilder.**withHttpClient** public.

Right know they are package-private, so the only way for us to set up anything is using setHttpClientBuilderCallback method.
That is not ideal, because we have to remember everything we set up inside our OkHttpClient.
For example, we were re-setting all interceptors, but totally forgot to also copy proxy settings.

Passing our own HttpClient would solve these problems.

[Android]

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.