dotnet / dotnet/aspnetcore

Add direct APIs for Http.Sys extensions currently using IHttpSysRequestInfoFeature

Open
#35,012 30 comments 0 reactions 0 assignees View on GitHub
area-networking feature-httpsys feature-iis
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 10h
Merged PRs (30d)
281

Description

We previously only exposed a ROM for `IHttpSysRequestInfoFeature` since underlying data structure in Http.Sys were still subject to change. Given that the underlying API is now stable (as I understand based on the Windows API docs), we should replace this feature in favor of a feature with typed-data.

Checklist to track exposing the data via explicit APIs:

- [ ] HttpRequestInfoTypeAuth,
- [ ] HttpRequestInfoTypeChannelBind,
- [ ] HttpRequestInfoTypeSslProtocol,
- [ ] HttpRequestInfoTypeSslTokenBindingDraft and HttpRequestInfoTypeSslTokenBinding
- [x] HttpRequestInfoTypeRequestTiming
- [x] HttpSys https://github.com/dotnet/aspnetcore/pull/48218
- [x] IIS https://github.com/dotnet/aspnetcore/pull/48663
- [ ] HttpRequestInfoTypeTcpInfoV0 and HttpRequestInfoTypeTcpInfoV1 (V1 is a superset of V0)
- [ ] HttpRequestInfoTypeRequestSizing
- [ ] HttpRequestInfoTypeQuicStats

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.