dotnet / dotnet/aspnetcore

Write more content directly to StreamWriter in W3CLogger

Open
#33,946 7 comments 0 reactions 0 assignees View on GitHub
area-networking help wanted Perf
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 5h
Merged PRs (30d)
276

Description

See https://github.com/dotnet/aspnetcore/pull/33251/#discussion_r655734742, https://github.com/dotnet/aspnetcore/pull/33251/#discussion_r656445769.

https://github.com/dotnet/aspnetcore/blob/3177376dca6ca0a6bba1d4ab946e77f02547c167/src/Middleware/HttpLogging/src/W3CLogger.cs#L49
> Since we know the only consumer of this data is StreamWriter, can you delay the Format, enqueue the elements array, and format when writing to the stream? This intermediate string is likely large and useless.

https://github.com/dotnet/aspnetcore/blob/3177376dca6ca0a6bba1d4ab946e77f02547c167/src/Middleware/HttpLogging/src/W3CLoggerProcessor.cs#L35
> More content that should be written directly to the streamWriter.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.