dotnet / dotnet/aspnetcore

SourceLink links are incorrect for submodules

Open
#32,063 9 comments 0 reactions 0 assignees View on GitHub
area-infrastructure blocked External
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 10h
Merged PRs (30d)
281

Description

```
The remote server returned an error: (404) Not Found.
Failed to retrieve https://raw.githubusercontent.com/dotnet/aspnetcore/93fd8baf5f9670f1123cfd73dddb608eca6f59c3/src/submodules/MessagePack-CSharp/src/MessagePack.UnityClient/Assets/Scripts/MessagePack/Utilities.cs
D:\workspace\_work\1\a\signed\shipping\assets\symbols\Microsoft.AspNetCore.App.Runtime.linux-arm.6.0.0-preview.4.21221.10.symbols.nupkg has broken SourceLink links.
```

These links are incorrect. The links for raw github content for a submodule should point to the other repos' raw content. E.g.

https://raw.githubusercontent.com/aspnet/MessagePack-CSharp/1fd19e6cc1a58bce9153933324164ec80ed560cf/src/MessagePack.UnityClient/Assets/Scripts/MessagePack/Utilities.cs

Contributor guide

Open the contributing guide

Research direction

Start by tracing how SourceLink URLs are generated for the aspnetcore submodule at src/submodules/MessagePack-CSharp, then compare the failing dotnet/aspnetcore raw URL with the expected aspnet/MessagePack-CSharp URL in the report. Validate the change against the generated symbols package and confirm that submodule files resolve to their source repository.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
build-system, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.