dotnet / dotnet/aspnetcore

MapFallbackTo* APIs are extremely inefficient

Open
#27,840 4 comments 0 reactions 0 assignees View on GitHub
area-mvc feature-routing Perf
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 6h
Merged PRs (30d)
290

Description

MapFallbackTo* (Controller, Page etc) APIs add a catch all route with a nonfile route constraint, but it also adds dynamic controller/page metadata, which allows it to match pages or controllers dynamically. The net effect of this is that all nodes in the DFA tree end executing any MatcherPolicy that contains dynamic page/controller metadata and in turn this causes all policies that affect pages or controllers to apply to *all* nodes in the graph.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.