dotnet / dotnet/aspnetcore

Verify consistent request body behavior around Upgrade

Open
#25,142 1 comment 0 reactions 0 assignees View on GitHub
affected-very-few area-networking severity-nice-to-have task
Dominant language
C#
Stars
38.4k
Forks
10.9k
Avg merge
2d 5h
Merged PRs (30d)
276

Description

It came up during https://github.com/dotnet/aspnetcore/pull/24984 that the servers probably have different behavior HttpRequest/Response.Body around Upgraded request. The [Upgrade API](https://github.com/dotnet/aspnetcore/blob/c21841f52e066400aae85a776f7b901fdca904e3/src/Http/Http.Features/src/IHttpUpgradeFeature.cs#L22) returns a bidirectional stream, but kestrel for example also allows you to read from the original request body stream after the upgrade.

Compare the different server behaviors and make sure they're at least consistent.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.