Call PipeWriter.CompleteAsync instead of PipeWriter.Complete
Open
affected-few
area-networking
severity-nice-to-have
task
- Dominant language
- C#
- Stars
- 38.4k
- Forks
- 10.9k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 281
Description
Now that PipeWriter.CompleteAsync() has been added (https://github.com/dotnet/corefx/issues/39241), we should call PipeWriter.CompleteAsync() wherever we call PipeWriter.Complete() today and wouldn't want to to sync-over-async IO. PipeWriter.Complete() can potentially do sync-over-async IO given a non-default PipeWriter. StreamPipeWriter is the big existing example of this since it will flush the stream in PipeWriter.Complete()/CompleteAsync().
@anurse @davidfowl @jkotalik
Contributor guide
Assessment
This issue has not been assessed yet.