dotnet / dotnet/arcade

Wix _GenerateMsiVersionString should be usable with the signed wix packages for workloads

Open
#8,076 1 comment 0 reactions 0 assignees View on GitHub
help wanted
Dominant language
C#
Stars
729
Forks
397
Avg merge
3d 15m
Merged PRs (30d)
149

Description

https://github.com/dotnet/arcade/blob/dfb902f38e7c68d8cd83d53f32ea174e8f3a310a/src/Microsoft.DotNet.Build.Tasks.Installers/build/wix/wix.targets#L46

.NET workload manifests need a way to generate correct msi versions but can't easily use the current _GenerateMsiVersionString wix target so we've had to duplicate the target in:
- https://github.com/dotnet/runtime/pull/60695
- https://github.com/dotnet/emsdk/pull/89

We'd like to get rid of that duplication and use shared code

cc @steveisok @joeloff @mmitche

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.