Remove ParseBuildNumber from GenerateMsiVersion
Open
help wanted
- Dominant language
- C#
- Stars
- 729
- Forks
- 397
- Avg merge
- 3d 15m
- Merged PRs (30d)
- 149
Description
https://github.com/dotnet/arcade/blob/main/src/Microsoft.DotNet.Build.Tasks.Installers/src/GenerateMsiVersion.cs#L69-L81
The ParseBuildNumber is really "GenerateMsiVersion for commit height based versioning"...
1. Commit height versioning shouldn't be in use
2. If the wrong parameters are passed, this can cause rollover in unexpected cases.
Contributor guide
Assessment
This issue has not been assessed yet.