wix targets shouldn't use DateTime.Now
Open
help wanted
- Dominant language
- C#
- Stars
- 729
- Forks
- 397
- Avg merge
- 3d 15m
- Merged PRs (30d)
- 149
Description
https://github.com/dotnet/arcade/blob/dfb902f38e7c68d8cd83d53f32ea174e8f3a310a/src/Microsoft.DotNet.Build.Tasks.Installers/build/wix/wix.targets#L54
Some of these targets could be called multiple times, and if this straddled a date boundary interesting things could happen. This should probably parse out the date from the build ID, since that will be stable.
Contributor guide
Assessment
This issue has not been assessed yet.