dotnet / dotnet/arcade

PKGProj referencing a project that only specifies TargetFramework doesn't work.

Open
#7,242 1 comment 0 reactions 1 assignee Claimed by @safern View on GitHub
area-Infrastructure-libraries help wanted
Dominant language
C#
Stars
729
Forks
397
Avg merge
3d 15m
Merged PRs (30d)
149

Description

I noticed this when looking at the Logging generator.

The generator only targeted `netstandard2.0`.

This caused https://github.com/dotnet/arcade/blob/e7ede87875f41a9b3df898ae08da5ebc96e24f56/src/Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk/src/build/Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk.targets#L122 to miss the single `TargetFramework` and silently drop the `ProjectReference` from the package.

Not sure if we should fix this with pkgproj going away, but it was pretty bad that it silently dropped. We should either error or handle the single `$(TargetFramework)`.

cc @maryamariyan

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.