dotnet / dotnet/arcade

Make Arcade's Helix builds use VSTest

Open
#6,858 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
C#
Stars
729
Forks
397
Avg merge
3d 15m
Merged PRs (30d)
149

Description

- [ ] This issue is blocking
- [ ] This issue is causing unreasonable pain

The way Arcade's builds send jobs to Helix was written using XUnit. XUnit lacks some of the flexibility that VSTests supports. In writing tests for SignCheck, I needed to update ARcade to spin up an entirely separate Helix queue just for the SignCheck tests. I also had to wire through utilizing the x86 console runner. I wrote the code to do this, but it's a lot of extra code, and not well vetted, yet.

https://github.com/dotnet/arcade/pull/6800#issuecomment-767121553

We could, either spend time reviewing those changes and testing this new feature of using the XUnit runner, or we could invest in https://github.com/dotnet/arcade/issues/4539. My preference is the latter, but I'm not sure where that is on the priority list and if it's worth waiting on that before we add tests for SignCheck. On the flip side, we haven't had any SignCheck unit tests up to this point, so it's hard to build a case on that data point and I'm unsure what to do with the SignCheck PR in the interim..

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.