dotnet / dotnet/arcade

Warn PR author when eng/common is modified in consumer repo

Open
#6,768 6 comments 1 reaction 0 assignees View on GitHub
help wanted
Dominant language
C#
Stars
729
Forks
397
Avg merge
3d 15m
Merged PRs (30d)
149

Description

In arcade-powered repos, eng/common is logically a (readonly) mirror directory, which dotnet-maestro bot dutifully updates.

If a PR is submitted by a human being that updates a file under this directory, it is easy to misremember during the PR review. That causes a merge conflict in the next arcade update and mostly results in reverting the manual changes made earlier.

It would be nice if a bot post a comment to such PRs to help reminding reviewers about readonly-ness of eng/common, something to the effect:

> Reminder: `eng/common` is a mirror directory. Please submit changes in dotnet/arcade repo to avoid conflicts during the subsequent arcade update.

ps: such reverts took place in dotnet/runtime repo few times, and currently eng/common in aspnetcore repo is diverged.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.