dotnet / dotnet/arcade

Use Factory pattern for BatchSignUtil

Open
#6,747 0 comments 0 reactions 0 assignees View on GitHub
TechnicalDebt
Dominant language
C#
Stars
729
Forks
397
Avg merge
3d 15m
Merged PRs (30d)
149

Description

BatchSignInput property was added to SignToolTask so that it could be exposed during unit testing validation. A cleaner solution would be to use the factory pattern and mock out BatchSignUtil so that the BatchSignInput values could be validated.

See https://github.com/dotnet/arcade/pull/6746#discussion_r552926462

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.