dotnet / dotnet/arcade

VersionTools CreateOrUpdateAsync doesn't support PullRequestOptions.ForceCreate = true

Open
#4,442 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
729
Forks
397
Avg merge
3d 15m
Merged PRs (30d)
149

Description

This if block covers the whole method including PR creation, rather than only skipping the parts that detect earlier PRs, so trying to force PR creation makes the method do nothing:

https://github.com/dotnet/arcade/blob/e1f099bf18a14e8ef5dc50f1a90078839aa102c8/src/Microsoft.DotNet.VersionTools/lib/src/Automation/PullRequestCreator.cs#L81

It looks like this was a mistake in this refactor: https://github.com/dotnet/buildtools/commit/91726ae38c66579e77cbd4437eb602217701f41e.

It should look more like it did before: https://github.com/dotnet/buildtools/blob/4642e67685b9c21c4d5160ea7665843a48ed8155/src/Microsoft.DotNet.VersionTools/Automation/PullRequestCreator.cs#L60-L112

Thanks @mthalman for pointing this out. /cc @MichaelSimons

(I don't have fixing this on my backlog as of writing, I'm filing this to track the known issue. Anyone can pick it up.)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.