dotnet / dotnet/arcade

[QCR][Final] Clean up eng/common/templates/post-build folder

Open
#4,347 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
729
Forks
397
Avg merge
3d 15m
Merged PRs (30d)
149

Description

- It's silly that there's no consistency between parameter names in different templates
ie. "[StageLabel](https://github.com/dotnet/arcade/blob/master/eng/common/templates/steps/publish-logs.yml#L2)" vs "[stageName](https://github.com/dotnet/arcade/pull/4344/files#diff-fb459e4b4cccf45ce665b4bc780235c2R7)"
- The folder name "post-build" doesn't really make sense because

- if it really means "post-build", then there's other things that are post-build, like tests

- it's all in the azure build pipeline now so there's not really a post-build thing happening

I'd prefer a name like "release"

- It feels like there's this pattern for templates under `/eng/common/templates` where templates are stored in the folder which represents the [type of template reference](https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=azure-devops&tabs=schema#stage-templates) they are, and then there's this "post-build" folder where there's a completely different convention for folder naming.

We should clean up our templates (parameter usage, filenames, etc...) and follow a defined convention rather than this wild west of template names / locations. The difficulty, at this point, is doing so without making it a breaking change.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.