dotnet / dotnet/arcade

SymStore.targets mistakenly assumes that PDB's are always named as $(TargetName).pdb

Open
#2,874 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
729
Forks
397
Avg merge
3d 15m
Merged PRs (30d)
149

Description

`_InnerDeployToSymStore` in [SymStore.targets](https://github.com/dotnet/arcade/blob/cdd5d318667c5af1740d69c8a7755e23e7964aeb/src/Microsoft.DotNet.Arcade.Sdk/tools/SymStore.targets#L25) assumes that `pdb` files are always named `$(TargetPath).ChangeExtension('.pdb')`.

This is not always true. For e.g., PDB's can (and sometime are) produced with different names. For e.g., WPF produces some PDB's with a different name (`-compile` suffix; see [this](https://github.com/dotnet/wpf/blob/f91e128b558f0657febf9a66691ccc2ab11d0dc2/eng/WpfArcadeSdk/tools/Wpf.Cpp.props#L229))

```xml

$(IntermediateOutputPath)$(TargetName)-compile.pdb
```

These PDB's are ignored during publishing.

Perhaps `_InnerDeployToSymStore` should be using a glob-pattern to search for PDB's instead of using a specific assumption about how PDB files are named.

/cc @dotnet/wpf-developers
/cc @rladuca
/cc @tmat

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.