dotnet / dotnet/arcade

Need to use more recent version of Roslyn in GenFacades

Open
#2,669 3 comments 0 reactions 0 assignees View on GitHub
area-Infrastructure-libraries help wanted
Dominant language
C#
Stars
729
Forks
397
Avg merge
3d 15m
Merged PRs (30d)
149

Description

https://github.com/dotnet/arcade/blob/0b36b99e29b1751403e23cfad0a7dff585818051/src/Microsoft.DotNet.GenFacades/Microsoft.DotNet.GenFacades.csproj#L19

The older version appears to be causing parsing problems in some cases when building corefx partial facades that use nullable annotations:
```
error : Unable to cast object of type 'Microsoft.CodeAnalysis.CSharp.Syntax.CompilationUnitSyntax' to type 'Microsoft.CodeAnalysis.CSharp.Syntax.BaseTypeDeclarationSyntax'
```

cc: @safern, @dotnet/nullablefc

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.