dotnet / dotnet/arcade

Change Warning to Information in Azure Helper retry code.

Open
#2,611 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
729
Forks
397
Avg merge
3d 15m
Merged PRs (30d)
149

Description

https://github.com/dotnet/arcade/blob/master/src/Microsoft.DotNet.Build.Tasks.Feed/src/common/AzureHelper.cs#L244

``` c#
try
{
using (var request = createRequest())
response = await client.SendAsync(request);
}
catch (Exception e)
{
loggingHelper.LogWarningFromException(e, true);

// if this is the final iteration let the exception bubble up
if (retries + 1 == retryCount)
throw;
}
```

Unfortunately there are lots of builds which have settings to treat warnings as errors, leading to this retry logic not being very helpful.

I recommend we make this a LogInformation() type call but with the string "warning" so folks don't think it's good that their build had to retry.

@chcosta FYI.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.